[codex] Export public client session types#60
Merged
Conversation
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Pull request overview
This PR updates the @quranjs/api/public entrypoint to expose OAuth/session-related types needed by consumers building custom public-client session storage.
Changes:
- Re-exports selected session/token types from
packages/api/src/public.ts. - Adds a patch changeset for
@quranjs/api.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/api/src/public.ts |
Adds type-only exports for public OAuth/session-related types. |
.changeset/public-type-exports.md |
Records the patch release note for the new public type exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
basit3407
force-pushed
the
codex/public-entrypoint-types
branch
from
7d76a97 to
61ef3d0
Compare
osamasayed
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59 by re-exporting the public OAuth session storage types from the
@quranjs/api/publicentrypoint.The runtime public entrypoint already uses these types in its declaration surface, but only
createPublicClientandPublicClientwere exported. Consumers importingTokenStorageorUserSessionfrom@quranjs/api/publichit TypeScript export errors even though the root package entrypoint exported them.Changes
TokenStorageandUserSessionfrompackages/api/src/public.tsas type-only exports.@quranjs/api.Validation
pnpm --filter @quranjs/api buildwith Nodev22.16.0pnpm --filter @quranjs/api exec vitest run test/public-types.test.ts test/public-client.test.tspnpm --filter @quranjs/api check:operation-catalogsC:\Code\qf-user-pocPOC check: in-memory TypeScript compile importingPublicClient,TokenStorage, andUserSessionfrom@quranjs/api/publicagainst the linked local SDK build