Skip to content

Fix collection bookmark deletion#177

Merged
AhmedNMahran merged 1 commit into
mainfrom
nabil/fix-collection-bookmark-delete
May 16, 2026
Merged

Fix collection bookmark deletion#177
AhmedNMahran merged 1 commit into
mainfrom
nabil/fix-collection-bookmark-delete

Conversation

@AhmedNMahran
Copy link
Copy Markdown
Collaborator

Summary

  • Fix collection bookmark deletion to delete by bookmark local id instead of collection-bookmark local id.
  • Add regression coverage where both ids differ.

Validation

  • ./gradlew :persistence:jvmTest --tests com.quran.shared.persistence.repository.CollectionBookmarksRepositoryTest

@AhmedNMahran AhmedNMahran requested a review from ahmedre May 16, 2026 13:17
@AhmedNMahran AhmedNMahran self-assigned this May 16, 2026
@AhmedNMahran AhmedNMahran requested a review from mohamede1945 May 16, 2026 13:18
@AhmedNMahran AhmedNMahran merged commit 129cf73 into main May 16, 2026
1 check passed
@AhmedNMahran AhmedNMahran deleted the nabil/fix-collection-bookmark-delete branch May 16, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants