feat(openapi/content): add foot_notes to GET /quran/translations/{translation_id}Feat foot notes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in random verse endpoint Added missing documentation for existing query parameters supported by the random verse endpoint: - chapter_number - page_number - juz_number - hizb_number - rub_el_hizb_number - ruku_number - manzil_number These parameters were already supported in the API but not reflected in the documentation. This update ensures developers are aware of all available filtering options when using the endpoint.
/tafsirs/{resource_id}/by_ayah/{ayah_key}
Fixed the incorrect response schema shown for the /tafsirs/{resource_id}/by_ayah/{ayah_key} endpoint in the docs.
The autogenerated version via <ApiTabs> was causing runtime crashes due to unresolved OpenAPI store references. Since that approach wasn't working despite correct infoPath and operationId setup, we manually wrote the MDX documentation using standard Docusaurus components.
Tested locally – page now renders successfully and reflects the accurate response structure.
list-ayah-tafsirs and regenerate MDX
Updated the OpenAPI schema (v4.json) for the /tafsirs/{resource_id}/by_ayah/{ayah_key} endpoint to ensure the response structure reflects the actual API output.
The previous crash with <ApiTabs> was due to incorrect or incomplete schema context. After fixing the schema, we ran:
- yarn clean-all
- yarn gen-all
- yarn start
The generated docs now render correctly and reflect the accurate response, eliminating the need for manual overrides.
Fix additional v4 typos
…haf--in-v4.json Fix Mushaf typo
…aceholders-in-v4.json Fix unrendered model placeholders
tokens with actual endpoints
…-tokens-in-v4.json Fix placeholder endpoints
…in-get-todays-plan-api Fix mushafId param docs
…fields-and-word_fields Add field reference documentation and links
…g-other-endpoints docs: link resource references
…ation-for-docusaurus Add JavaScript SDK docs
…in v4.json (param, schema, and examples)
…mestamps; correct schema & examples)
GET /quran/translations/{translation_id}
Add optional boolean query param foot_notes (default: false).
When foot_notes=true, include foot_notes object mapping footnote IDs (from <sup> tags) to their text.
Update response schema and example to document the foot_notes map.
No MDX changes; docs will be generated from openAPI/content/v4.json.
Affected:
openAPI/content/v4.json
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@basit3407 there is a merge conflict |
|
@osamasayed I have resolved the conflicts. Please free to review and merge. JAK! |
osamasayed
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional boolean
foot_notesquery param toGET /quran/translations/{translation_id}.When
true, response includes afoot_notesmap keyed by footnote IDs (from<sup>tags) to their text.Changes
openAPI/content/v4.jsonto define thefoot_notesquery param.foot_notesobject to the response schema (additionalProperties: string).API Impact
false→ no change to existing responses unless explicitly requested.Docs
openAPI/content/v4.json.Verification
foot_noteswhen the flag is not set.