-
Notifications
You must be signed in to change notification settings - Fork 1
update amberff usage & other improvements #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 - add todo to qprep
…both QligFEP & setupFEP
…g to NEP 29. For more information, check openforcefield/openff-toolkit#2041 (openFF folks aren't going to keep on testing for 3.10 in the long run, it seems)
…of 24 cores instead of the desirable 16 for running QligFEP
…our when passing `ligand_only` to the method
For now, that's only coded for POPC but it might change in the future
…n passing CSB as cluster
Dynamically calculate water droplet density taking lipid atoms into account
jesperswillem
approved these changes
Jul 30, 2025
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the large PR, but this includes all the changes to be introduced on the QligFEPv2 paper. From now on, let's work with smaller PR's since that makes it easier to track the different changes. Current changes include:
Q's aminoacid reading from pdb to 4 characters to enable proper N & C termini detectionFEP_submit.shsupports replicate-based job re-submissionwater_threshparameter.FF.prm&FF.libfiles that include parametrized co-factorsTo improve:
water_threshwon't make a distinction between the ligand and the POPC atoms. It would be beneficial to have a different treatment to these atom typesslurmjob arrays. This is something to be improved in the futureINPUTSfiles in favor of string advanced formatting