Issues/433 plotting isinstance fail #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do this?) and use it to check types
shumpohl
commented
Mar 11, 2019
qupulse/pulses/plotting.py
Outdated
| return _render_loop(program, sample_rate=sample_rate, | ||
| render_measurements=render_measurements, time_slice=time_slice) | ||
| else: | ||
| raise ValueError('Cannot render an object of type %s', type(program)) |
There was a problem hiding this comment.
This is bad. There should be a %
thangleiter
approved these changes
Mar 11, 2019
|
Apparently the mocking of sys.modules does not work. |
Pull Request Test Coverage Report for Build 1699
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433 which occures if a reload is triggered (ipython and spyder do this sometimes).
I implemented a custom
has_type_interface. Something tells me that there has to be a better more standard way.