Fix vm start silently deleting provisioned WSL distros#2
Merged
qwatts-dev merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
The isProvisioned check relied solely on an external .provisioned marker file. Distros provisioned before the marker system was introduced (or whose marker was lost) were incorrectly identified as unprovisioned and silently deleted on the next vm start. Changes: - isProvisioned() now has a two-tier check: marker file first, then falls back to checking /etc/trellis-project-root (breadcrumb written during bootstrap) inside the distro. Self-heals the marker on success. - vm start now prompts for confirmation before deleting a distro that appears unprovisioned, instead of silently deleting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vm startrelied solely on an external.provisionedmarker file to determineif a WSL distro was fully set up. Distros provisioned before the marker system
was introduced were incorrectly flagged as unprovisioned and silently deleted.
Fix
pkg/wsl/manager.go—isProvisioned()now has a two-tier check:.provisionedmarker file on Windows (fast, existing behavior)/etc/trellis-project-rootbreadcrumb inside the distro(written during bootstrap). If found, self-heal the marker so future checks
are instant.
cmd/vm_start.go— If both checks fail, prompt the user for confirmationbefore deleting. Never silently destroy a distro.