Skip to content

Add asset management#234

Merged
zleyyij merged 28 commits intomainfrom
assets
Nov 6, 2024
Merged

Add asset management#234
zleyyij merged 28 commits intomainfrom
assets

Conversation

@zleyyij
Copy link
Contributor

@zleyyij zleyyij commented Oct 14, 2024

Draft PR so I can see the nightmare of a MR I have created

closes #65

@TheKrol
Copy link
Contributor

TheKrol commented Nov 4, 2024

image
Maybe it is just me, but building it in production gives me this error

@TheKrol
Copy link
Contributor

TheKrol commented Nov 4, 2024

There is also an issue when I upload an image, I get an invalid header error (which you cannot close) and it gives me unsaved changes until I refresh then the site works.

Copy link
Contributor

@TheKrol TheKrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would limit they types of files you can select because I can upload a 5gb iso to the assets. I would also just put a size limit on it just incase

@zleyyij
Copy link
Contributor Author

zleyyij commented Nov 4, 2024

image Maybe it is just me, but building it in production gives me this error

I was unable to replicate this @TheKrol

@zleyyij
Copy link
Contributor Author

zleyyij commented Nov 4, 2024

There is also an issue when I upload an image, I get an invalid header error (which you cannot close) and it gives me unsaved changes until I refresh then the site works.

I'm unable to replicate this @TheKrol, I'm uploading an image and it doesn't error, could you screenshot the error and/or provide more detailed reproduction instructions?

@zleyyij zleyyij requested a review from TheKrol November 4, 2024 20:00
@zleyyij
Copy link
Contributor Author

zleyyij commented Nov 4, 2024

Everything you brought up has been addressed now @TheKrol

@TheKrol
Copy link
Contributor

TheKrol commented Nov 4, 2024

Thank you sir, I appreciate you. Do you want another test run through?

@zleyyij
Copy link
Contributor Author

zleyyij commented Nov 4, 2024

I don't think that'll be necessary, I just made some itty bitty changes, thank you :)

@zleyyij zleyyij merged commit b007c4b into main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for uploading/deleting/modifying assets

3 participants