Skip to content

feat: Add adbi to check matrix #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviator-app merged 3 commits into from
Dec 16, 2023
Merged

feat: Add adbi to check matrix #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3e55bb
feat: Add adbi to check matrix
krlmlr Dec 16, 2023
bcaa15e
REVERT ME: Remove duckdb for now
krlmlr Dec 16, 2023
b14a0f9
Prefer doubles over integers for adbi
krlmlr Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions R/spec-arrow-read-table-arrow.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,21 @@ spec_arrow_read_table_arrow <- list(
arrow_read_table_arrow_closed_connection = function(ctx, con, table_name) {
#' @section Failure modes:
#' An error is raised when calling this method for a closed
dbWriteTable(con, table_name, data.frame(a = 1))
dbWriteTable(con, table_name, data.frame(a = 1.5))
con2 <- local_closed_connection(ctx = ctx)
expect_error(dbReadTableArrow(con2, table_name))
},

arrow_read_table_arrow_invalid_connection = function(ctx, con, table_name) {
#' or invalid connection.
dbWriteTable(con, table_name, data.frame(a = 1))
dbWriteTable(con, table_name, data.frame(a = 1.5))
con2 <- local_invalid_connection(ctx)
expect_error(dbReadTableArrow(con2, table_name))
},

arrow_read_table_arrow_error = function(ctx, con, table_name) {
#' An error is raised
dbWriteTable(con, table_name, data.frame(a = 1L))
dbWriteTable(con, table_name, data.frame(a = 1.5))
#' if `name` cannot be processed with [dbQuoteIdentifier()]
expect_error(dbReadTableArrow(con, NA))
#' or if this results in a non-scalar.
Expand All @@ -81,7 +81,7 @@ spec_arrow_read_table_arrow <- list(

for (table_name in table_names) {
local_remove_test_table(con, table_name)
test_in <- data.frame(a = 1L)
test_in <- data.frame(a = 1.5)
dbWriteTable(con, table_name, test_in)

#' - If an unquoted table name as string: `dbReadTableArrow()` will do the
Expand Down
5 changes: 3 additions & 2 deletions revdep-dev/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ all: test
TESTTHAT_REPORTER ?= testthat::ProgressReporter\$$new(max_failures = Inf, update_interval = Inf)

# The REVDEP definition also decides what is run on GitHub Actions in backends.yaml
REVDEP := RMariaDB RSQLite RPostgres RKazam duckdb odbc-sql-server odbc-mysql odbc-postgres odbc-sqlite
# FIXME: Re-add duckdb, very slow on GitHub Actions
REVDEP := RMariaDB RSQLite RPostgres RKazam adbi odbc-sql-server odbc-mysql odbc-postgres odbc-sqlite
TEST_TARGETS := $(patsubst %,test-%,${REVDEP})

LIB_DIR := $(shell Rscript -e "cat(.libPaths()[1])")

install:

RKazam RSQLite RPostgres RMySQL RMariaDB odbc:
RKazam RSQLite RPostgres RMySQL RMariaDB odbc adbi:
# Use local checkout if available, otherwise clone from r-dbi GitHub
if [ -d ../../$@ ]; then ln -s $$(realpath ../../$@) .; else git clone https://github.com/r-dbi/$@.git; fi
head $@/DESCRIPTION
Expand Down