Struct field fixes for LcdScreenEffect_s and MaterialAsset_t #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waveOffset comes before waveScale.
Engine reads it out as 64-bit, write it as 64-bit.
Used for bloom luminance.
Material V12's output data was incorrect after the change in d7842d0. Revert this for now (it is currently also unknown whether V12 has 4 or 8 samplers, but only 4 are ever filled on all observed materials so reverting to that, as V12 also uses 4 blend states instead of 8 like V15 does, so its very likely it also only has 4 samplers).
IJARika
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect order of members in LcdScreenEffect_s, and makes MaterialAsset_t::samplers 64 bit (game reads it up to 64bit in len).