fixed max(), min(), range() for multiple inputs if one is non-finite#181
fixed max(), min(), range() for multiple inputs if one is non-finite#181MichaelChirico merged 29 commits intor-lib:mainfrom hcirellu:main
Conversation
|
Thanks! Please add regresion tests |
|
Regression tests added and reverted to |
|
Is there anything more to do or can it be merged? |
I just need to find some time, hopefully this weekend. |
MichaelChirico
left a comment
There was a problem hiding this comment.
Sorry for the extra round of review. I tried making these edits directly myself but because your PR is from your main branch, I am unable to do so (or otherwise, you didn't grant me access to edit your fork)
I thought I allowed it. I'll check. |
# Conflicts: # tests/testthat/test-integer64.R
MichaelChirico
left a comment
There was a problem hiding this comment.
OK I think this is ready to go. Thanks!!
For #142
The example in issue #142 now works correctly.
I also fixed the behaviour that the warning is also shown in the case of range(NA_integer64_, na.rm=TRUE).
The same is applied to min.integer64 and max.integer64.