support zero length input in match.integer64#191
Merged
MichaelChirico merged 4 commits intor-lib:mainfrom Nov 13, 2025
Merged
Conversation
MichaelChirico
approved these changes
Nov 13, 2025
| # trivial cases for zero length input | ||
| if (!length(x)) return(integer()) | ||
| if (!length(table)) { | ||
| nomatch = as.integer(c(nomatch, NA_integer_)[1L]) |
Collaborator
There was a problem hiding this comment.
I finally understood how the R code works, it's somewhat unexpected:
The C-level coercion asInteger() always needs to return a single int value, so its behavior differs from as.integer() which returns integer() when encountering NULL.
Collaborator
|
Thanks! Just minor points about GitHub itself:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero length input for
xandtabletomatch.integer64should result in consistent results asmatchwithinteger.Closes #190