Remove CI from 3.6.0, add one for 3.4.0 instead#196
Merged
MichaelChirico merged 10 commits intomainfrom Dec 30, 2025
Merged
Conversation
hcirellu
pushed a commit
to hcirellu/bit64
that referenced
this pull request
Jan 2, 2026
* fix locale-gen issue on 3.4.0 container * don't call method in package code * extend generic_call_in_stack to work for ns::foo calls * local options to ignore warnings under later TODO * bit:: -qualify in test sources * methods:: -qualify in test sources * extend+fix script for CI to work on R 3.4.0 * Use ubunut-latest to solve 'queued' issue (?) * install bit * ws issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The {testthat} suite now requires fairly recent R, so using the default suite on ancient R won't really work.
Instead, I've employed Gemini to fix up & extend the existing .devcontainer/r-340/.Rprofile script to work for testing R on the ancient version.
Tested within a codespace; will iterate here in the PR to ensure it works as intended in CI too.
Also includes a few required touch-ups that come from shedding the formal {testthat} shell, in particular internal names no longer resolve (i.e., {testthat} makes all of
ls(asNamespace("bit64"))available, whereas now we only uselibrary(bit64)).