Skip to content

remove base from S3method call in NAMESPACE#235

Merged
MichaelChirico merged 1 commit intor-lib:mainfrom
hcirellu:s3_methods_on_primitives
Jan 12, 2026
Merged

remove base from S3method call in NAMESPACE#235
MichaelChirico merged 1 commit intor-lib:mainfrom
hcirellu:s3_methods_on_primitives

Conversation

@hcirellu
Copy link
Copy Markdown
Collaborator

Removing the base:: prefix in s3method() in Namespace, in order to not have the warnings in ancient R.

Closes #234

This time I opened the PR from r-lib/bit64. Did that help?

@hcirellu hcirellu marked this pull request as ready for review January 12, 2026 16:44
@MichaelChirico MichaelChirico merged commit e8fd497 into r-lib:main Jan 12, 2026
10 checks passed
@MichaelChirico
Copy link
Copy Markdown
Collaborator

This time I opened the PR from r-lib/bit64. Did that help?

hm, still no... it was opened from your fork:

Screenshot_2026-01-12-09-02-22-31_40deb401b9ffe8e1df2f1cc5ba480b12

for me, in git push origin $BRANCH, origin indicates r-lib/bit64 (see git remote -v). That's what I have in mind -- pushing to the r-lib/bit64 branch (however that's named for you)

@hcirellu
Copy link
Copy Markdown
Collaborator Author

I tried to push to r-lib/bit64, but it seems that I don't have the permissions to do that.

@hcirellu
Copy link
Copy Markdown
Collaborator Author

What about granting you write permissions to my fork?

@MichaelChirico
Copy link
Copy Markdown
Collaborator

I tried to push to r-lib/bit64, but it seems that I don't have the permissions to do that.

I see, I thought I'd invited you for that. Check your e-mail, I just sent out another invite.

@hcirellu
Copy link
Copy Markdown
Collaborator Author

I found your invitation and accepted it.
From now on I would create new branches direclty from main in r-lib/bit64 and not based on my fork. Is my understanding correct?

@MichaelChirico
Copy link
Copy Markdown
Collaborator

I found your invitation and accepted it. From now on I would create new branches direclty from main in r-lib/bit64 and not based on my fork. Is my understanding correct?

That would be most appreciated! 🙏

@hcirellu
Copy link
Copy Markdown
Collaborator Author

All right. I'll try my best. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning on old R from using 'base::' qualification in NAMESPACE

2 participants