Skip to content

fix intdiv and modulo#263

Merged
MichaelChirico merged 1 commit intomainfrom
modulo_2
Feb 28, 2026
Merged

fix intdiv and modulo#263
MichaelChirico merged 1 commit intomainfrom
modulo_2

Conversation

@hcirellu
Copy link
Copy Markdown
Collaborator

In PR #248 the following case was overseen, which is not consistent to R:

7L%%(-10L)
# [1] -3
as.integer64(7L)%%(-10L)
# integer64
# [1] 7

This is fixed now.

I had to change round.integer64 because of the change. Now it is faster, too.

@hcirellu
Copy link
Copy Markdown
Collaborator Author

This PR is required to enable the full test in PR #249.

@hcirellu hcirellu marked this pull request as ready for review February 27, 2026 16:29
@MichaelChirico MichaelChirico merged commit 282cd20 into main Feb 28, 2026
10 checks passed
@MichaelChirico MichaelChirico deleted the modulo_2 branch February 28, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants