Treat '...' like missing() in AST#276
Merged
MichaelChirico merged 5 commits intomainfrom Mar 5, 2026
Merged
Conversation
Collaborator
MichaelChirico
left a comment
There was a problem hiding this comment.
another test case I had in mind is a helper passing ... something like
getter = function(x, ...) x[...]calling that directly and with lapply should work
Collaborator
Author
This works now: getter = function(x, ...) x[...]
getter(integer64())
# integer64(0)
getter(integer64(), "sss")
# integer64(0)
lapply(integer64(), getter)
# list()
lapply(integer64(1), getter)
# [[1]]
# integer64
# [1] 0
lapply(integer(), getter)
# list()
lapply(integer(1), getter)
# [[1]]
# [1] 0 |
Collaborator
|
Great! Let's add it to the test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #275.
I added a special handling for symbol
...in[.integer64.The example in the related issue is added to the tests.
Closes #275