Un-export unused generics#281
Merged
MichaelChirico merged 6 commits intomainfrom Mar 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273. Because of the difficulty in avoiding false positives when looking for generic calls in the stack, and because I suspect needling aroud the stack at every invocation of a method winds up being too expensive, I think it's time to just rip the band-aid off here.
We might try and restore this approach for the to-be-unexported methods during the next development cycle, to possibly start eliciting some feedback if anyone is working from our development version (we haven't gotten any reports thus far that indicate to me this is likely, but who knows).