Skip to content

Use escape code 49 to close bg_br_* ANSI styles#485

Merged
gaborcsardi merged 2 commits intor-lib:mainfrom
rossellhayes:close-bg_br
Jun 19, 2022
Merged

Use escape code 49 to close bg_br_* ANSI styles#485
gaborcsardi merged 2 commits intor-lib:mainfrom
rossellhayes:close-bg_br

Conversation

@rossellhayes
Copy link
Contributor

bg_br_* ANSI styles previously closed with escape code 39, which restores the default foreground color, rather than escape code 49, which restores the default background color.

This PR fixes the escape code to allow the bg_br_*() functions to properly close themselves:

Closes #484.

@gaborcsardi
Copy link
Member

Thanks! If you don't mind, could you pls add an entry to NEWS.md, mentioning your issue and your GH username? Thanks!

@rossellhayes
Copy link
Contributor Author

@gaborcsardi Thanks, added!

@gaborcsardi gaborcsardi merged commit ac6c412 into r-lib:main Jun 19, 2022
@gaborcsardi
Copy link
Member

Thanks!

@rossellhayes rossellhayes deleted the close-bg_br branch July 15, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bright background colors (bg_br_*() functions) are not properly closed

2 participants