Stricter generics and improved error messages#347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304
Closes #286 (good enough at this point)
calendar_*()generics now require calendarsdate_*()generics now require date or date time as appropriatetime_point_*()generics now require time pointsI think ideally I would make
get_*(),set_*(), andinvalid_*()restricted generics as well, since they are mainly intended for use with the clock API, but datetimeoffset uses them already. It isn't a huge deal.It does make sense for
as_*()to be extensible (althoughas_date()andas_date_time()are sort of exceptions in my head, because converting to Date throughas_date()has a very careful meaning, i.e. thinking of Date as a naive date). I may reconsider my reluctance of adding...to theas_*()functions, and if I did add...then I'd do it for all of them in one fell swoop. It does sort of make sense to ensure it is easy to get into a clock type.