Feature add error message for incorrect decorators #180
Conversation
sbearrows
changed the title
R/register.R
Outdated
|
|
||
| out <- decorations[decorations$decoration == tag, ] | ||
|
|
||
| if(any(!decorations$decoration %in% c("cpp11::register", "cpp11::init"))) { |
There was a problem hiding this comment.
maybe store the result in a variable to make this easier to read?
e.g.
bad_decorations <- !decorations$decoration %in% c("cpp11::register", "cpp11::init")
if (any(bad_decorations)) { # etc..
R/register.R
Outdated
| out <- decorations[decorations$decoration == tag, ] | ||
|
|
||
| if(any(!decorations$decoration %in% c("cpp11::register", "cpp11::init"))) { | ||
| lines <- decorations$line[which(!decorations$decoration %in% c("cpp11::register", "cpp11::init"))] |
There was a problem hiding this comment.
The which() is unnecessary here, you can just index with the logical vector directly.
R/register.R
Outdated
| if(any(!decorations$decoration %in% c("cpp11::register", "cpp11::init"))) { | ||
| lines <- decorations$line[which(!decorations$decoration %in% c("cpp11::register", "cpp11::init"))] | ||
| if(length(lines) > 1) { | ||
| stop(call. = FALSE, paste0("Can't capture cpp11 decorators on lines ", |
There was a problem hiding this comment.
Maybe the error should be something like
cpp11 attributes must be either `cpp11::register` or `cpp11::init`:
- Invalid attribute [[cpp11::foobar]] on line 123 in file xyz.
- Invalid attribute [[cpp11::baz]] on line 456 in file abc.
There was a problem hiding this comment.
Oh that looks great!
Is the best way to make multi-line error messages by using a combination of paste() statements with sep = "\n" ? Or would this be a message() following by an empty stop() ?
There was a problem hiding this comment.
You can actually use glue to do this a little more nicely, something like this (untested, might need tweaks)
bad_lines <- glue::glue_collapse(
glue::glue("- Invalid attribute `{names}` on line {line} in file '{file}'."),
"\n"
)
msg <- glue::glue("
cpp11 attributes must be either `cpp11::register` or `cpp11::init`:
{bad_lines}
")
stop(msg, call. = FALSE)
|
I think maybe we should pull this check out into a separate |
|
fixes #127 |
2 participants
First pass for adding this error message. Error message could prolly still be more informative but let me know what you think!