add a workflow to check clang-format #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a convenience
make formattarget to call clang-format on**/*.hpp. Checks for clang-format-10 specifically to avoid the subtle differences between clang-format versions.Concerns:
I'd like to run this onGenerated code is marked with**/*.cppas well, butcpp11test/src/cpp11.cppis generated and I'm not sure formatting it is appropriate. Alsocpp11test/R/cpp11-bindings.cppwould match that glob and is also generated but it seems it should be namedcpp11test/R/cpp11-bindings.R?// clang-format offmakeconditionals andfindto implement globbing, version checking, etc. It might be preferable to move that logic to an R scriptformatRor similar