Conversation
|
|
||
| pkg <- as.package(pkg) | ||
|
|
||
| if (!is.null(email)) { |
There was a problem hiding this comment.
The mac builder doesn't seem to use the email or send you results via email, so it is possible we should just remove this functionality for this. What do you think?
| #' @family build functions | ||
| #' @return The url with the check results (invisibly) | ||
| #' @export | ||
| check_mac_release <- function(pkg = ".", args = NULL, manual = TRUE, email = NULL, quiet = FALSE, ...) { |
There was a problem hiding this comment.
Currently it seems the only thing the public API allows is to check on R-release and the M1 macs. Though the response from the POST request indicates future plans to support more versions of R and architectures, e.g.
> httr::content(res)
$submitted
[1] TRUE
$id
[1] "1637073137-c5c2e7a4dcbedebf"
$package
[1] "glue"
$version
[1] "1.5.0.9000"
$rflavor
[1] "r-release"
$rfw
[1] "4.1-arm64"
$url
[1] "https://mac.R-project.org/macbuilder/results/1637073137-c5c2e7a4dcbedeb
f/"
| encode = "multipart" | ||
| ) | ||
|
|
||
| httr::stop_for_status(res) |
There was a problem hiding this comment.
Do you think we need a custom error message here, or is the default error for a bad status sufficient?
There was a problem hiding this comment.
You could use task = "Uploading package" as a compromise
| time <- strftime(Sys.time() + 30 * 60, "%I:%M %p") | ||
|
|
||
| cli::cli_alert_success( | ||
| "[{Sys.Date()}] Check {.url {response_url}} for a link to results in 15-30 mins (~{time})." |
There was a problem hiding this comment.
This time was based on win-builder times, it seems conservative for the typical mac-builder times, should we leave it or change it?
There was a problem hiding this comment.
I think change it.
If the times are pretty short, is it worth adding a polling mode?
There was a problem hiding this comment.
I guess the other thing is the results page seems to auto-refresh itself, so we could alternatively just use utils::browseURL() to open it for the user? (maybe only if it is interactive and !quiet?)
|
I haven't yet added support for custom additional dependencies, but this is a first pass at |
- Removed the email argument - added support for custom dependencies - added `task` argument to `stop_for_status()`
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Sorry, meant to approve earlier.
2 participants
Fixes #2375