Parameter browser in file_show() fixed#154
Merged
jimhester merged 2 commits intor-lib:masterfrom Nov 21, 2018
GegznaV:fix-file_show-browser
Merged
Parameter browser in file_show() fixed#154jimhester merged 2 commits intor-lib:masterfrom GegznaV:fix-file_show-browser
browser in file_show() fixed#154jimhester merged 2 commits intor-lib:masterfrom
GegznaV:fix-file_show-browser
Conversation
The parameter `browser` was not used in the body the function `file_show()`.
Member
|
Thanks looks good! Can you add a note to NEWS.md mentioning this issue number and your github username, thanks! |
Contributor
Author
|
I updated |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter
browserwas not used in the body the functionfile_show()thus it was not working as expected.