ci: Test all R versions on branches that start with cran-#163
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the R CMD check workflow to enable comprehensive R version testing on branches with names starting with "cran-". The change ensures that CRAN submission branches receive the same thorough testing as scheduled runs and external pull requests.
Changes:
- Modified the
versions-matrixstep condition to include internal PRs from branches starting with "cran-" - Simplified the
rcc-fulljob condition to run whenever a versions matrix is available, removing the restriction to only scheduled runs or manual dispatch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-" | ||
| # Do not run for: |
There was a problem hiding this comment.
The comment does not accurately describe the conditional logic. The comment states "pull requests if the base repo is different from the head repo and the branch name does not start with 'cran-'", which suggests an AND condition with a negative check. However, the actual code on line 141 uses OR logic: it runs for pull requests when either the base repo differs from the head repo OR when the branch name starts with "cran-". The comment should be updated to reflect that this step runs for pull requests from external repositories OR for internal pull requests with branches starting with "cran-".
| # - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-" | |
| # Do not run for: | |
| # - pull requests if the base repo is different from the head repo OR the branch name starts with "cran-" | |
| # - workflow_dispatch if explicitly requested via the "versions-matrix" input | |
| # Do not run for: | |
| # - pull requests from the same repository when the branch name does not start with "cran-" |
No description provided.