removed oauth_flow_check() in oauth_flow_device #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flahn
commented
Sep 19, 2022
flahn
commented
- fixes Problems with Device Code + PKCE authentication on remote machines #170
- checking interactiveness at that point prevented the code block about printing url and device code for manual browser interaction from being ever executed
- fixes r-lib#170 - checking interactiveness at that point prevented the code block about printing url and device code for manual browser interaction from being ever executed
Member
|
Can you please add a bullet to the top of |
- oauth_flow_check() should handle still the object check of `client`, but disable the check about interactiveness
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.