Skip to content

removed oauth_flow_check() in oauth_flow_device #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2022
Merged

removed oauth_flow_check() in oauth_flow_device #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f1741e
removed oauth_flow_check() in oauth_flow_device
flahn Sep 19, 2022
94645e4
readded the oauth_flow_check() with rlang::is_interactive()
flahn Sep 21, 2022
c4b36e4
NEWS entry
flahn Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# httr2 (development version)

* disabled check for interactive session `oauth_flow_check(..., interactive)` on device code flow to print URL and device code as intended (@flahn, #170)

* The environment variable `HTTR2_REFRESH_TOKEN` replaces the previous `HTTR_REFRESH_TOKEN` (@jennybc, #169).

* OAuth tokens can now be refreshed. One, two, or even more times! (@jennybc, #166)
Expand Down
2 changes: 1 addition & 1 deletion R/oauth-flow-device.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ oauth_flow_device <- function(client,
scope = NULL,
auth_params = list(),
token_params = list()) {
oauth_flow_check("device", client, interactive = TRUE)
oauth_flow_check("device", client, interactive = is_interactive())

if (pkce) {
code <- oauth_flow_auth_code_pkce()
Expand Down