Conversation
Member
Author
|
@mgirlich what do you think of the name? |
jonthegeek
reviewed
Aug 25, 2023
Contributor
jonthegeek
left a comment
There was a problem hiding this comment.
This looks super useful! Some thoughts on the name:
req_cookie_file()makes it feel like the thing I care about is the file, moreso than the reuse of the cookies.- Would it make sense to align it with the
cache_diskandcache_keyoptions from the_auth_functions? It's not QUITE the same thing but feels similar.
I guess the difference here is that you could conceivably supply a file from some other source, whereas caching is more internal and automatic.
So after talking it out... I can't think of anything that makes more sense to me than req_cookie_file().
mgirlich
reviewed
Aug 29, 2023
mgirlich
reviewed
Aug 29, 2023
mgirlich
approved these changes
Aug 29, 2023
Collaborator
|
Basically, |
Member
Author
|
Oh I like |
Co-authored-by: Maximilian Girlich <maximilian.girlich@metoda.com>
Member
Author
|
@jonthegeek the implementation here is pretty limited by what curl provides; it has to be written out to disk. |
#Conflicts: # NEWS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223