Skip to content

Make it easier to generate repeated query parameters#352

Merged
hadley merged 4 commits intomainfrom
query-splat
Oct 20, 2023
Merged

Make it easier to generate repeated query parameters#352
hadley merged 4 commits intomainfrom
query-splat

Conversation

@hadley
Copy link
Copy Markdown
Member

@hadley hadley commented Oct 17, 2023

Fixes #350

Copy link
Copy Markdown
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was JUST working around this about a week ago. Thanks!

Comment thread NEWS.md Outdated
@hadley hadley requested review from jonthegeek and mgirlich October 19, 2023 17:47
@hadley
Copy link
Copy Markdown
Member Author

hadley commented Oct 19, 2023

I'm much happier with this new approach.

Copy link
Copy Markdown
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo. This will be super useful! Wonderful timing, since I just had to look up what the heck "explode" meant for an API definition last week!

Do you want to mention the function option in the news bullet?

Comment thread R/req-url.R Outdated
@jonthegeek
Copy link
Copy Markdown
Contributor

BTW, this seems like the correct approach, but does it contradict https://design.tidyverse.org/independent-meaning.html ?

Comment thread R/req-url.R Outdated
Comment thread R/req-url.R Outdated
Comment thread R/req-url.R Outdated
Co-authored-by: Jon Harmon <jonthegeek@gmail.com>
Co-authored-by: Maximilian Girlich <maximilian.girlich@metoda.com>
@hadley
Copy link
Copy Markdown
Member Author

hadley commented Oct 20, 2023

@jonthegeek hmmm, maybe I'm splitting hairs, but I don't think this changes the meaning, it just changes how vectors are handled in the output.

@jonthegeek
Copy link
Copy Markdown
Contributor

@hadley I think you're correctly splitting hairs. It might be worth examining those hairs and mentioning them in that chapter, though 😊

@hadley hadley merged commit a04dc72 into main Oct 20, 2023
@hadley hadley deleted the query-splat branch October 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pass multi-value parameters as vectors to GET

3 participants