Allow scheduling boost::function#41
Closed
wch wants to merge 1 commit into
Closed
Conversation
Member
Author
|
In order for code from another package to schedule a I think it should be possible to do this by providing something like an abstract class or interface that doesn't require boost, but I don't know for sure. |
Member
|
Implemented using a subclass instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it simpler to schedule functions like the ones mentioned here:
rstudio/httpuv#106 (review)
@jcheng5, before merging, we should discuss the object lifetime issues that came up in an earlier conversation. I don't think that they will be a problem here.
I think we avoided adding this in the past because of concerns that it would introduce a boost dependency, but I don't think that this PR is actually adding such a dependency.