Skip to content

Improve warnings in indirect usages#137

Merged
lionel- merged 5 commits intomainfrom
fix-indirect
Sep 22, 2022
Merged

Improve warnings in indirect usages#137
lionel- merged 5 commits intomainfrom
fix-indirect

Conversation

@lionel-
Copy link
Copy Markdown
Member

@lionel- lionel- commented Sep 22, 2022

Branched from #136.
Closes #135.

In case of indirect usage:

  • Don't warn every time.
  • Recommend reaching out to the authors of the package that used the deprecated feature.

@lionel- lionel- requested a review from hadley September 22, 2022 16:02
Copy link
Copy Markdown
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

Comment thread R/deprecate.R Outdated
Comment thread R/deprecate.R
Comment thread R/deprecate.R
"The deprecated feature was likely used in the {.pkg {pkg}} package."
),
" " = cli::format_inline(
"Please report the issue to the authors."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be scope create, but is it worth doing some lightweight parsing of packageDescription("purrr")$BugReports and adding a clickable link if it starts with https://?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup I'll take a look, and also do it in abort(.internal = TRUE) which is a feature @DavisVaughan also requested.

@lionel- lionel- changed the base branch from cli to main September 22, 2022 16:32
@lionel- lionel- merged commit a5b1a24 into main Sep 22, 2022
@lionel- lionel- deleted the fix-indirect branch September 22, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only message at most every 8 hours for indirect deprecations

2 participants