Skip to content

Bypass signal() to avoid validation and cli related overhead #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavisVaughan merged 1 commit into from
Oct 3, 2025
Merged

Bypass signal() to avoid validation and cli related overhead #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions R/signal.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,25 +28,28 @@ signal_stage <- function(stage, what, with = NULL, env = caller_env()) {
what <- spec(what, env = env)

if (is_null(what$arg)) {
msg <- sprintf("%s() is %s", what$fn, stage)
message <- sprintf("%s() is %s", what$fn, stage)
} else {
msg <- sprintf("%s(%s) is %s", what$fn, what$arg, stage)
message <- sprintf("%s(%s) is %s", what$fn, what$arg, stage)
}

if (!is_null(with)) {
with <- spec(with, NULL, "signal_stage")
msg <- paste0(msg, "\n", lifecycle_message_with(with, what))
message <- paste0(message, "\n", lifecycle_message_with(with, what))
}

signal(
msg,
"lifecycle_stage",
# Much faster than calling `rlang::signal()` directly.
# `message` is already formatted so we don't need to worry about cli.
cnd_signal(cnd(
Copy link
Member

@hadley hadley Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the condition object directly with structure()? (like simpleCondition())

Copy link
Member

@hadley hadley Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, and use signalCondition()?

Copy link
Member Author

@DavisVaughan DavisVaughan Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #195 for the fully lazy way

class = "lifecycle_stage",
message = message,
stage = stage,
package = what$pkg,
function_nm = what$fn,
argument = what$arg,
reason = what$reason
)
reason = what$reason,
use_cli_format = FALSE
))
}

#' Deprecated functions for signalling experimental and lifecycle stages
Expand Down