Fix packaging step for GitHub installs with a subdirectory#290
Merged
Conversation
Including updating the cache, and selecting the right package from the cache.
A leftover package tree might be in the cache directory, and then a later install picks that up instead of the binary package file from the cache.
Take the subdirrectory from the metadata, that is available when using a lock file.
Member
|
Thanks! I had to understand this again, so I refactored it a bit, fixed another issue, and added tests. Will merge once the CI is green. |
Not needed any more, because we use a fake GH for testing.
No reason that we should keep them, I think.
Member
|
Thanks again! |
This was referenced Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes r-lib/pak#431 locally (but I'm rather unfamiliar with the consequences this might have for other types of package installs).
If it's helpful, my local tests were:
...and