Skip to content

Consistently use scss variables#1740

Merged
hadley merged 61 commits intomasterfrom
madeleines
Oct 14, 2021
Merged

Consistently use scss variables#1740
hadley merged 61 commits intomasterfrom
madeleines

Conversation

@maelle
Copy link
Collaborator

@maelle maelle commented Jul 27, 2021 •
edited
Loading

To-dos.

  • Setting navbar colors, checking it looks ok with different types and bg.
  • Adding docs. In particular document the "gray magic" and the non magic (if you set body-color, not fg, the grays aren't a mix of the body-color and bg).
  • Special variables for copy-paste button?
  • How should code highlighting colors be theme-able (probably out-of-scope but to keep in mind).
  • Add a different rule for the color of links in inline code (should follow the color other links).

maelle
maelle commented Jul 27, 2021
View reviewed changes
@maelle maelle changed the base branch from macaron to master July 29, 2021 07:59
maelle
maelle commented Jul 30, 2021
View reviewed changes
maelle
maelle commented Jul 30, 2021
View reviewed changes
@maelle
Copy link
Collaborator Author

maelle commented Sep 2, 2021

Ah! I didn't realize we'd be able to access our own bslib variables using the bslib YAML key! For some reason, I thought those were more "under the hood". Thank you!

Is this a good interface?

@maelle maelle mentioned this pull request Sep 22, 2021
Closed
@hadley
Merge commit '632889250b23aae88d6b3adcc0afd48160cb17ca'
3582af0 
Conflicts:
	R/development.R
	R/package.r
	inst/assets/BS4/pkgdown.css
	inst/assets/BS4/syntax-highlighting.css
	tests/testthat/test-build-search-docs.R
@hadley
Merge fixes
bea9133
hadley
hadley reviewed Sep 27, 2021
View reviewed changes
@hadley hadley marked this pull request as ready for review October 13, 2021 20:09
@hadley hadley changed the title start using variables in a better way Consistently use scss variables Oct 13, 2021
hadley added 3 commits October 14, 2021 07:28
@hadley
Remove redundant display-4
70d6b82
@hadley
Fix data_deps()
931c8ce 
* No longer adds commas on home page
* No longer adds two copies of every dep
@hadley
More theme tweaking
1929ca4
@hadley
Copy link
Member

hadley commented Oct 14, 2021

Fixes #1678
Fixes #1686
Fixes #1695
Fixes #1698

@hadley hadley merged commit 07cf601 into master Oct 14, 2021
@hadley hadley deleted the madeleines branch October 14, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hadley hadley hadley left review comments

+2 more reviewers

@cderv cderv cderv left review comments

@apreshill apreshill apreshill left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maelle @apreshill @hadley @cderv