Parallelize build_articles() and build_reference()#745
Parallelize build_articles() and build_reference()#745pat-s wants to merge 3 commits intor-lib:masterfrom
build_articles() and build_reference()#745Conversation
|
This kills the current progress reporting which makes errors difficult to debug. I think it requires more thought before we add parallel support to pkgdown. |
I turned it off on purpose. If you prefer to keep the progress reporting using the "Reading/writing" approach as it applies for the sequential execution, I'll change it again. What other potential problems do you have in mind that I am not aware off? |
|
I would bet that I saw "Reading/Writing" output when I first integrated I changed the code to use half of all cores so that it does not conflict with vignettes having parallel code. I would not see the requirement for debugging; the sequential mode can be used for this. Once one is sure that everything works, the parallel mode can be used. If this PR is most likely not going to be merged/useful right now, feel free to close it. |
#744
Uses
future_mapandfuture_walkfrom thefurrrpackage ifparallel = TRUEis set inbuild_site(),build_articles()orbuild_reference().New arguments
Comments
By default all cores are used. It may be better to use only 50% by default as using all cores might conflict with vignettes that use parallelization themselves.
By default, the "Reading", "Writing" output is suppressed when building in parallel in favor of a progress bar. This is opinionated. What's your opinion on this? Another option would be to only suppress the "Reading", "Writing" output if argument
progress = TRUEand to show it otherwise.Example