Merged
Conversation
Now we throw an error if R CMD check exits with an exit status greater than 1. (It exists with 1 if the package fails to install, which we don't want to error on.) Closes #110.
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 81.57% 81.09% -0.48%
==========================================
Files 19 19
Lines 993 1005 +12
==========================================
+ Hits 810 815 +5
- Misses 183 190 +7
Continue to review full report at Codecov.
|
- need to encode file name string when generating code. - tools::pskill() does not work on windows, use ps.
In case of crashes.
Give more time for the rcmdcheck R process to exit.
It crashes on Windows.
They are unstable.
They must be ASCII to work on Windows.
readChar() converts \n to \r\n on Windows...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we throw an error if R CMD check exits with an
exit status greater than 1. (It exists with 1 if the
package fails to install, which we don't want to
error on.)
Closes #110.