-
Notifications
You must be signed in to change notification settings - Fork 72
Release package version 1.8.0 #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1036 +/- ##
=======================================
Coverage 91.08% 91.08%
=======================================
Files 46 46
Lines 2691 2691
=======================================
Hits 2451 2451
Misses 240 240 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if cd860bf is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
|
@IndrajeetPatil can you have a look? In particular to the |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ed1535b is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good!
The only thing that bothers me is that some of the news items start with uppercase letters, while others with lowercase. I was going to change it, but NEWS says that we should not edit it by hand. So not sure.
But this is not something that shouldn't block the release. We can punt it to a later date.
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 503f2c6 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
|
It's on CRAN! 🎉 |
|
Yes. 🥳 I will sort out the git tagging, wait a few hours (so {pkgdwn} recognizes 1.8 as a released CRAN version) and then merge. I guess we could also write a blog post on tidyverse.com and summarize all new features since the last post. Are you interested to contribute to that? |
|
Sure, would love to contribute! |
|
Great work!! Thank you both!! |
Prepare for release:
devtools::check_win_devel()email.ymlthenrevdepcheck::revdep_email_maintainers()cran-comments.mdurlchecker::url_check("path/to/pkg")Perform release:
NEWS.mddevtools::submit_cran()pkgdown::build_site()Wait for CRAN...
NEWS.mdfor new features.