Skip to content

Conversation

@lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Oct 22, 2022

Prepare for release:

  • devtools::check_win_devel()
  • Polish NEWS
  • add tidy thanks.
  • If new failures, update email.yml then revdepcheck::revdep_email_maintainers()
  • update cran-comments.md
  • run urlchecker::url_check("path/to/pkg")

Perform release:

  • Create RC branch (for bigger releases)
  • Bump version (in DESCRIPTION and NEWS)
  • add tidy thanks to NEWS.md
  • devtools::submit_cran()
  • pkgdown::build_site()
  • Approve email

Wait for CRAN...

  • Tag release
  • Merge RC back to master branch
  • Bump dev version
  • update CRAN speed change monitor PR.We have a new CRAN release coming up 🥳 See NEWS.md for new features.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #1036 (f832104) into main (990a031) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files          46       46           
  Lines        2691     2691           
=======================================
  Hits         2451     2451           
  Misses        240      240           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if cd860bf is merged into main:

  •   :ballot_box_with_check:cache_applying: 30.1ms -> 30.2ms [-2.88%, +3.96%]
  •   :ballot_box_with_check:cache_recording: 826ms -> 827ms [-0.39%, +0.74%]
  •   :ballot_box_with_check:without_cache: 2.06s -> 2.06s [-0.14%, +0.57%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert marked this pull request as draft October 22, 2022 17:44
@lorenzwalthert
Copy link
Collaborator Author

@IndrajeetPatil can you have a look? In particular to the NEWS.md for spelling mistakes etc. Once approved, I can submit.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ed1535b is merged into main:

  •   :ballot_box_with_check:cache_applying: 26.1ms -> 26.1ms [-2.92%, +2.78%]
  •   :ballot_box_with_check:cache_recording: 733ms -> 733ms [-0.62%, +0.82%]
  •   :ballot_box_with_check:without_cache: 1.85s -> 1.85s [-0.68%, +0.95%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good!

The only thing that bothers me is that some of the news items start with uppercase letters, while others with lowercase. I was going to change it, but NEWS says that we should not edit it by hand. So not sure.

But this is not something that shouldn't block the release. We can punt it to a later date.

@lorenzwalthert lorenzwalthert marked this pull request as ready for review October 22, 2022 20:11
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 503f2c6 is merged into main:

  •   :ballot_box_with_check:cache_applying: 26.7ms -> 27.1ms [-2.04%, +4.88%]
  •   :ballot_box_with_check:cache_recording: 757ms -> 758ms [-0.24%, +0.39%]
  •   :ballot_box_with_check:without_cache: 1.91s -> 1.91s [-0.5%, +0.29%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil
Copy link
Collaborator

It's on CRAN! 🎉

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Oct 23, 2022

Yes. 🥳 I will sort out the git tagging, wait a few hours (so {pkgdwn} recognizes 1.8 as a released CRAN version) and then merge. I guess we could also write a blog post on tidyverse.com and summarize all new features since the last post. Are you interested to contribute to that?

@IndrajeetPatil
Copy link
Collaborator

Sure, would love to contribute!

@MichaelChirico
Copy link
Contributor

Great work!! Thank you both!!

@lorenzwalthert lorenzwalthert merged commit 2fc151e into main Oct 24, 2022
@lorenzwalthert lorenzwalthert deleted the rc-1.8.0 branch October 24, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants