Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logical operators in square brace expression and line breaks #709

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Jan 3, 2021

Closes #563 and puts the code in same rule for efficiency.

Here is how the current PR would change benchmark results when merged into master:

  • cache_applying: 0.03 -> 0.03 (-0.6%)
  • cache_recording: 0.89 -> 0.89 (0.4%)
  • without_cache: 2.6 -> 2.55 (-2%)

@codecov-io
Copy link

Codecov Report

Merging #709 (4dfb4ce) into master (e1688f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   90.45%   90.46%           
=======================================
  Files          47       47           
  Lines        2253     2254    +1     
=======================================
+ Hits         2038     2039    +1     
  Misses        215      215           
Impacted Files Coverage Δ
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/style-guides.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1688f5...4dfb4ce. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit f840c15 into r-lib:master Jan 3, 2021
@lorenzwalthert lorenzwalthert deleted the issue-563 branch January 3, 2021 10:31
@lorenzwalthert lorenzwalthert restored the issue-563 branch February 20, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No line-break before |and & should be allowed
2 participants