{{ message }}

# Handle directories in tests folder. Fixes #138 #146

Closed
wants to merge 2 commits into from
Closed

# Handle directories in tests folder. Fixes #138#146

wants to merge 2 commits into from

## Conversation

### KentonWhite commented May 30, 2014

 Watchers use digest to efficiently check if a file has changed. Digest does not handle missing files or directories well. So safe_digest was written to wrap digest and catch errors. In b1cb9e8 it was discovered that the error catching was too optimistic and was eating errors that should be reported to the user. To fix this, logic was added to catch the known errors from digest and re-raise all other errors. The only known error at that time was if the file did not exist. Unfortunately digest also throws an error if it is passed a directory. With the introduction of the new testthat tests folder structure, all tests folders also include a subfolder called testthat. When digest was passed the folder name it was failing. Rather than filtering for folders, I've expanded the known errors logic. The list of known errors is now encapsulated in a known_errors function. An error is checked against this list, and if it isn't found then the error is re-raised. I also ran into problems with the tests in test-watcher. test-watcher was explicitly testing internal functions, and I was having trouble with the testing environment not finding these functions. I explicitly export these functions if they are not in the current testing environment. This is probably stupid and would love some pointers as to a better way to test!
 # In an interactive environment # Get these functions from the testthat namespace if(!exists('dir_state')) {

#### hadley Jun 6, 2014 Member

I don't understand what you're doing here

#### KentonWhite Jun 6, 2014 Author

Both dir_state and compare_state are not exported. Running the tests locally, I was getting errors since they weren't in the global name space. This is my kludge to get the testing to work: if the function is not available in the global namespace, get the function from the testthat namespace. There is probably a better way to do this!

#### hadley Jun 6, 2014 Member

You can use devtools::test(, "test-watcher")) to run the tests in a single file. That's the easiest way to make sure the tests are run in the correct environment.

#### KentonWhite Jun 6, 2014 Author

Great! That works. Pulling the confusing code out.

### KentonWhite commented Jun 20, 2014

 I've removed the confusing lines from the test. Was that the only issue that came up in code review?

### hadley commented Jun 23, 2014

added 2 commits May 30, 2014
 Handle directories in tests folder. Fixes #138 
 e9a89ff 
Watchers use digest to efficiently check if a file has changed.
Digest does not handle missing files or directories well. So safe_digest
was written to wrap digest and catch errors.

In b1cb9e8 it was discovered that
the error catching was too optimistic and was eating errors that should
be reported to the user. To fix this, logic was added to catch
the known errors from digest and re-raise all other errors.

The only known error at that time was if the file did not exist.
Unfortunately digest also throws an error if it is passed a directory.
With the introduction of the new testthat tests folder structure,
all tests folders also include a subfolder called testthat. When
digest was passed the folder name it was failing.

Rather than filtering for folder, I've expanded the known errors logic.
The list of known errors is now encapsulated in a known_errors function.
An error is checked against this list, and if it isn't found then the
error is re-raised.
 Merge branch 'master' of github.com:hadley/testthat 
 62803fc 
Conflicts:
NEWS.md

### KentonWhite commented Jun 25, 2014

 Added a bullet point to News. Travis is failing with the warning Warning: /tmp/RtmpDScBVE/Rbuild1b14f561f1f/testthat/man/testthat.Rd:26: unknown macro '\em'  Don't think this change has caused that!

### hadley commented Sep 17, 2014

 Can you please rebase/merge against master?
closed this in  e3353f7  Sep 17, 2014