Mock in more environments #1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hadley
commented
Apr 26, 2023
hadley
commented
- In package environment for interactive use
- In actual test environment for testing + S3 support
* In package environment for interactive use * In actual test environment for testing + S3 support
jennybc
approved these changes
Apr 26, 2023
R/mock2.R
Outdated
| #' incorporating what we've learned from the mockr, mockery, and mockthat | ||
| #' packages. | ||
| #' | ||
| #' `with_mocked_bindings()` and `local_mocked_bindings()` work by temporarily |
Member
There was a problem hiding this comment.
Re: the slack message about "any good description of mocking that people might grok"
Maybe: with_mocked_bindings() and local_mocked_bindings()` work by temporarily redefining an object (usually a function) provided by a package.
I feel like "(re)defining an object" might speak to more people than talking about bindings.
R/mock2.R
Outdated
| #' implementation changes. | ||
| #' Generally, it's only safe to mock packages that you own. | ||
| #' | ||
| #' These functions do not currently affect registered S3 methods. |
Member
Author
There was a problem hiding this comment.
I've tried to clarify this a bit more — I think the danger is that you're not just affecting the functions in your package, but all the other functions in that package. (i.e. in the rlang case you're affecting every rlang function that calls check_installed(), not just your functions).
lionel-
approved these changes
Apr 27, 2023
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
So interactive mocking of S3 methods works
jennybc
reviewed
Apr 27, 2023
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.