Skip to content

Default to not running helpers when loading #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2023
Merged

Default to not running helpers when loading #1841

merged 2 commits into from
Aug 1, 2023

Conversation

@hadley
Copy link
Member

@hadley hadley commented Aug 1, 2023

No description provided.

@hadley hadley requested a review from jennybc August 1, 2023 21:30
jennybc
jennybc approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixes the apparent double test helper loading surfaced in recent work in gmailr.

@hadley hadley merged commit 4c6bf28 into main Aug 1, 2023
@hadley hadley deleted the no-helpers-by-default branch August 1, 2023 22:20
@hadley hadley mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennybc jennybc jennybc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hadley @jennybc