Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Oct 7, 2025

To preserve same behaviour as previously

To preserve same behaviour as previously
@claude
Copy link

claude bot commented Oct 7, 2025

Claude finished @hadley's task —— View job


Reviewing PR changes

  • Read modified files to understand changes
  • Analyze tolerance-related modifications
  • Check for potential bugs or issues
  • Provide review feedback

Changes analyzed:

  • Added tolerance = testthat_tolerance() parameter to expect_waldo_equal_() call in expect_mapequal() (line 112)
  • Added new test case to verify integer/numeric differences are ignored

Review:

LGTM. The change correctly restores the tolerance behavior that was lost when reverting PR #2150.

The addition of tolerance = testthat_tolerance() ensures expect_mapequal() ignores integer/numeric differences (like 1L vs 1) in edition 3, maintaining consistency with expect_equal(). The test case appropriately validates this behavior.

@hadley hadley merged commit a5b1fbb into main Oct 7, 2025
14 checks passed
@hadley hadley deleted the mapequal-tolerance branch October 7, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants