Skip to content

expect_mapequal() needs to set tolerance #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

expect_mapequal() needs to set tolerance #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/expect-setequal.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ expect_mapequal <- function(object, expected) {
} else {
if (edition_get() >= 3) {
act <- labelled_value(act$val[exp_nms], act$lab)
expect_waldo_equal_("equal", act, exp)
expect_waldo_equal_("equal", act, exp, tolerance = testthat_tolerance())
} else {
# Packages depend on 2e behaviour, but the expectation isn't written
# to be reused, and we don't want to bother
Expand Down
4 changes: 4 additions & 0 deletions tests/testthat/test-expect-setequal.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ test_that("warns if empty vector", {
expect_snapshot(expect_success(expect_mapequal(list(), list())))
})

test_that("ignores integer/numeric differences", {
expect_success(expect_mapequal(list(a = 1L), list(a = 1)))
})

test_that("uses equality behaviour of current edition", {
local_edition(2)
expect_success(expect_mapequal(c(a = 1), c(a = 1L)))
Expand Down