A few inverted expectiations#305
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
I think you accidentally included this line
Member
Author
There was a problem hiding this comment.
Good catch. I was wondering if this function necessary at all, we already have expect_error(..., NA)
added 4 commits
October 6, 2015 22:30
- also show difference
Member
Author
|
Removed expect_success(). Another option would be to support an optional argument: |
Member
|
I'd also feel better if they were named |
Member
Author
|
Added shorter versions: lt, lte, mt, mte |
Member
|
I think gt (greater than) is the more common abbreviation |
Member
Author
|
Now using gt. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expect_success()-- if failure should not abort the testexpect_less_than_or_equal()andexpect_more_than_or_equal()With tests. Modeled as "new-style" expectations, the arguments of the
_or_equalvariants differ.Also adds
expect_silent()to the "expectations" family.expect_unnamed()seems unnecessary, asexpect_named()can already test for absence of names.@hadley: Do you want to export
expect()at some point?Fixes #303.