New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure_msg and success_msg for throws_error #342

Merged
merged 3 commits into from Jan 12, 2016

Conversation

Projects
None yet
2 participants
@nealrichardson
Contributor

nealrichardson commented Jan 11, 2016

I noticed that expect_error was oddly printing that the "code raised an error" when the expectation correctly failed on code that did not error. Turns out the failure_msg and success_msg arguments were in the wrong order in throws_error. Test and fix.

@hadley

This comment has been minimized.

Member

hadley commented Jan 12, 2016

Oops! Could you please also add a bullet to NEWS.

@nealrichardson

This comment has been minimized.

Contributor

nealrichardson commented Jan 12, 2016

Done: 2367d60

@hadley

This comment has been minimized.

Member

hadley commented Jan 12, 2016

Can you cite your github username and this issue too please?

@nealrichardson

This comment has been minimized.

Contributor

nealrichardson commented Jan 12, 2016

hadley added a commit that referenced this pull request Jan 12, 2016

Merge pull request #342 from nealrichardson/master
Fix failure_msg and success_msg for throws_error

@hadley hadley merged commit be428eb into r-lib:master Jan 12, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jan 12, 2016

Thanks! Fwiw you can just say "PTAL" when you need me to take another look.

krlmlr pushed a commit to krlmlr/testthat that referenced this pull request Jan 13, 2016

Kirill Müller
Merge branch 'master' into throws-error-fix
Overriding changes of r-lib#342, because they were already implemented here (albeit differently).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment