Summary of skipped tests#343
Merged
Merged
Conversation
Member
|
I like the idea, but I think the output could be more compact, e.g.: |
Member
|
This might also be a good template for how to handle warnings (#310) |
Member
Author
|
Implemented more compact output. |
Merged
8307196 to
6369008
Compare
Member
Author
|
Related: #310. |
Member
Author
|
@hadley: How to include the context in the output, if at all? (Same question for error and warning output.) |
Member
Author
|
Print file + line rather than context: #352 |
Member
Author
|
There are two possible file + line locations to report: The test that failed/warned/skipped, and the actual code that causes the error/warning/skip. The former should be always available, even if the latter is not (#352 (comment)). |
Member
|
I think we should try for the actual line of code, and fall back to the test. |
Closed
Member
Author
|
This is complete "as is", file + line information should be handled separately (#352). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows skipped tests, but only if there are no failures. Example:
Will improve the coding once we agree on the concept.
Fixes #234.
CC @HarlanH @kenahoo-windlogics
Fixes #349 (=includes it).