Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of skipped tests #343

Merged
merged 7 commits into from Feb 18, 2016
Merged

Summary of skipped tests #343

merged 7 commits into from Feb 18, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 13, 2016

Shows skipped tests, but only if there are no failures. Example:

Testing bigrquery
DBItest: Connection : ..SS..S.SS
1. Skip: DBItest: cannot_query_disconnected --------------------------------------------------------------------------------------------------------------
Not yet implemented

2. Skip: DBItest: cannot_disconnect_twice ----------------------------------------------------------------------------------------------------------------
by request

3. Skip: DBItest: stress_connections ---------------------------------------------------------------------------------------------------------------------
by request

4. Skip: DBItest: get_info_connection --------------------------------------------------------------------------------------------------------------------
Not yet implemented

5. Skip: DBItest: stress_load_connect_unload -------------------------------------------------------------------------------------------------------------
by request

DONE 

Will improve the coding once we agree on the concept.

Fixes #234.

CC @HarlanH @kenahoo-windlogics

Fixes #349 (=includes it).

@hadley
Copy link
Member

@hadley hadley commented Jan 13, 2016

I like the idea, but I think the output could be more compact, e.g.:

Skip: 

1. DBItest: cannot_query_disconnected - Not yet implemented
2. DBItest: cannot_disconnect_twice - by request
3. DBItest: stress_connections - by request
4. DBItest: get_info_connection - Not yet implemented
5. DBItest: stress_load_connect_unload - by request
@hadley
Copy link
Member

@hadley hadley commented Jan 13, 2016

This might also be a good template for how to handle warnings (#310)

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 25, 2016

Implemented more compact output.

@krlmlr krlmlr mentioned this pull request Jan 25, 2016
@krlmlr krlmlr force-pushed the krlmlr:234-skip-summary branch from 8307196 to 6369008 Jan 25, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 25, 2016

Related: #310.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 25, 2016

@hadley: How to include the context in the output, if at all? (Same question for error and warning output.)

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 26, 2016

Print file + line rather than context: https://github.com/hadley/testthat/issues/352

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 27, 2016

There are two possible file + line locations to report: The test that failed/warned/skipped, and the actual code that causes the error/warning/skip. The former should be always available, even if the latter is not (https://github.com/hadley/testthat/issues/352#issuecomment-175241596).

@hadley
Copy link
Member

@hadley hadley commented Jan 27, 2016

I think we should try for the actual line of code, and fall back to the test.

@krlmlr krlmlr mentioned this pull request Jan 29, 2016
@krlmlr krlmlr changed the title WIP: Summary of skipped tests Summary of skipped tests Feb 18, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Feb 18, 2016

This is complete "as is", file + line information should be handled separately (#352).

hadley added a commit that referenced this pull request Feb 18, 2016
@hadley hadley merged commit 57dc3ce into r-lib:master Feb 18, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants