Skip to content

Use deep cloning of reporters in auto_test() and auto_test_package()#456

Closed
krlmlr wants to merge 5 commits into
r-lib:masterfrom
krlmlr:feature/441-deep-clone-reporter
Closed

Use deep cloning of reporters in auto_test() and auto_test_package()#456
krlmlr wants to merge 5 commits into
r-lib:masterfrom
krlmlr:feature/441-deep-clone-reporter

Conversation

@krlmlr
Copy link
Copy Markdown
Member

@krlmlr krlmlr commented Apr 16, 2016

Fixes #441. CC @nealrichardson.

Also uses withr::with_envvar() instead of devtools::with_envvar() to avoid warning.

Testing auto_test() and auto_test_package() is tricky, but not impossible. An external R script that runs for a certain time can be started using a pattern like this:

system("Rscript -e 'Sys.sleep(Inf)' & sleep 1")

The output of that script could be then analyzed by the test.

NEWS entry:

- `auto_test()` and `auto_test_package()` show only the results of the current test run and not of previously failed runs (#456, @krlmlr).

@hadley
Copy link
Copy Markdown
Member

hadley commented Apr 18, 2016

Merged manually

@hadley hadley closed this Apr 18, 2016
@krlmlr krlmlr deleted the feature/441-deep-clone-reporter branch May 7, 2016 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants