Use deep cloning of reporters in auto_test() and auto_test_package()#456
Closed
krlmlr wants to merge 5 commits into
Closed
Use deep cloning of reporters in auto_test() and auto_test_package()#456krlmlr wants to merge 5 commits into
krlmlr wants to merge 5 commits into
Conversation
added 5 commits
April 16, 2016 21:30
to avoid aliasing of contents of reporter members that are R6 objects
to work around r-lib/R6#85
Member
|
Merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #441. CC @nealrichardson.
Also uses withr::with_envvar() instead of devtools::with_envvar() to avoid warning.
Testing auto_test() and auto_test_package() is tricky, but not impossible. An external R script that runs for a certain time can be started using a pattern like this:
The output of that script could be then analyzed by the test.
NEWS entry: