Merged
Conversation
jimhester
reviewed
Jul 19, 2019
| vctrs (>= 0.1.0), | ||
| xml2 | ||
| xml2, | ||
| testthat (>= 2.1.0) |
Member
There was a problem hiding this comment.
This may not hurt anything, but it is kind of weird for testthat to Suggest itself.
Member
Author
There was a problem hiding this comment.
Ooops, I guess we need to special case use_test()
jimhester
reviewed
Jul 19, 2019
| }) | ||
|
|
||
| test_that("can't record plots", { | ||
| expect_error(verify_output("path", plot(1:10)), "Plots") |
Member
There was a problem hiding this comment.
This test opens a plot window, not sure the best way to avoid this and still run this test.
jimhester
reviewed
Jul 19, 2019
| "Output" | ||
| 1 + 2 | ||
| invisible(1:10) | ||
| 12345678 + 12345678 + 12345678 + 12345678 + 12345678 + 12345678 + |
Member
There was a problem hiding this comment.
Setting the width option must need to be moved slightly, as with a larger width option this output is different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to create a new regression test focussed on human readable output
Fixes #782. Fixes #834.