helper for preparing URLs for use_course()#821
Conversation
from the URLs that Google Drive and GitHub provide from their websites
jennybc
left a comment
jennybc
left a comment
There was a problem hiding this comment.
Thanks. I made a few small comments or mini-changes.
Can you add a test with expectations for DropBox, Google Drive, and a URL that matches neither regex?
Do you want to change the title of the PR to better reflect what it became, i.e. a helper for preparing URLs for use_course()?
We need to deal with the matter of exporting this helper (or not).
R/course.R
Outdated
| #' **Google Drive:** | ||
| #' | ||
| #' It looks like it's not possible to directly share as a ZIP file the content | ||
| #' of a folder storred in Google Drive. It is however possible to share a ZIP |
There was a problem hiding this comment.
Bummer. I really thought this was possible, but from my own searching, I agree there doesn't seem to be a workflow that is comparable to what we have for DropBox or GitHub.
|
@fmichonneau are you interested in finishing this off? |
|
yes, I'm interested in finishing this. I'll get to it in the next few days. Thanks for the reminder. |
fmichonneau
left a comment
fmichonneau
left a comment
There was a problem hiding this comment.
@jennybc I included the changes you suggested and added the tests. While testing this, I realized there was a different format that Google Drive would sometimes use when generating URLs for sharing that I tried to include here. I'm sure the regex can be improved 😩
I exported it but looking more at the code for the other functions included here, I'm not sure it's the right call. Let me know what you think. Thanks!
fmichonneau
changed the title
|
@jennybc I think this is good to merge, but needs final approval from you. |
|
I think this fixes #406? |
|
Thanks! |
|
thank you both for polishing and merging this! |
4 participants
Closes #406