add use_data_table() for Import-ing data.table#924
Merged
hadley merged 8 commits intor-lib:masterfrom Oct 22, 2019
Merged
Conversation
Closed
jangorecki
reviewed
Oct 20, 2019
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
Why not import(data.table). We are quite careful about masking other functions
Contributor
Author
|
Thanks @jangorecki, see new commit |
hadley
reviewed
Oct 21, 2019
Co-Authored-By: Hadley Wickham <h.wickham@gmail.com>
hadley
reviewed
Oct 21, 2019
R/data-table.R
Outdated
| #' `data.table` defines; see the 'Importing data.table' vignette for more | ||
| #' advice (`vignette('datatable-importing', 'data.table')`). | ||
| #' @export | ||
| use_data_table = function() { |
Member
|
Thanks! Last job is to add a bullet to NEWS: it should briefly describe the change and end with |
Contributor
Author
|
Top or bottom of the stack? NVM seems top |
Contributor
Author
|
@hadley nothing for |
Contributor
Author
|
For Travis, I'm seeing this in the logs, seems unrelated to current PR |
Member
|
I don't see much benefit for tests here, as there's not much new logic in |
Member
|
Thanks @MichaelChirico! |
Contributor
Author
|
my pleasure! thanks for the support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #897
A first pass at this. Please have a look @jangorecki.
Comments/feedback welcome.