Skip to content

ci: Fix comment#64

Merged
krlmlr merged 1 commit into
mainfrom
actions-sync-update
Jan 13, 2026
Merged

ci: Fix comment#64
krlmlr merged 1 commit into
mainfrom
actions-sync-update

Conversation

@krlmlr
Copy link
Copy Markdown
Member

@krlmlr krlmlr commented Jan 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 06:55
@krlmlr krlmlr merged commit cc524d3 into main Jan 13, 2026
4 checks passed
@krlmlr krlmlr deleted the actions-sync-update branch January 13, 2026 06:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates a comment in the R-CMD-check workflow to clarify when the versions-matrix step runs for pull requests. The comment was split into two separate bullet points to better describe the conditions.

Changes:

  • Rewrote the comment to use two separate bullet points instead of one compound statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +137 to 141
# - pull requests if the base repo is different from the head repo
# - pull requests if the branch name starts with "cran-"
# Do not run for:
# - workflow_dispatch if not requested
# Always run for other events.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment inaccurately describes the condition logic. The actual if condition at line 142 uses OR logic between the two pull request conditions, not separate conditions. The comment should clarify that the step runs for pull requests when EITHER the base repo is different from the head repo OR the branch name starts with "cran-", not as two separate cases.

Suggested change
# - pull requests if the base repo is different from the head repo
# - pull requests if the branch name starts with "cran-"
# Do not run for:
# - workflow_dispatch if not requested
# Always run for other events.
# - pull requests when either the base repo is different from the head repo OR the branch name starts with "cran-"
# - all other events, except workflow_dispatch when not requested
# Do not run for:
# - workflow_dispatch if not requested (inputs.versions-matrix is false or not set)
# For non-pull_request events (other than restricted workflow_dispatch), always run.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants