Fix uniform bucket access issue #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can close #202, but a bit of attention is required prior to merging (see below)
This PR adds a
predefinedAclargument that is passed through*_as_ee, thoughlocal_to_gcs, and then togoogleCloudStorageR::gcs_upload.It additionally updates tests to cover this case. Some of these tests rely on a bucket with uniform access, currently hardcoded in
testthat.RasPrior to merging @csaybar might want to either delete the above function and the new tests in
test-upload.Ror (preferably?) set up this bucket in your own testing infrastructure so that these tests can run. I thought it would be a good idea to get test coverage here so that CRAN will helpgoogleCloudStorageRto avoid changes in thepredefinedAclargument that could break things forrgee.I have not verified that the contents of this new uniform-access bucket will get properly deleted when the tests finish. This needs to be verified and updated if necessary.
I've bumped the version number of
googleCloudStorageRin Suggests from5.1to6.0because I'm too lazy to verify which version number first included thepredefinedAclargument.I've also tweaked
local_to_gcsso that ifquiet = FALSEandgoogleCloudStorageR::gcs_uploaderrors repeatedly, the user will see the error returned on the final try (seeing this error will help the user recognize if they need to change thepredefinedAclargument).